swift-module-digester: include operator overloads in the module dump. #19620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test Linux platform |
jrose-apple
reviewed
Sep 29, 2018
| Func BinaryInteger.>>(_:_:) has been added as a protocol requirement | ||
| Func BinaryInteger.>>=(_:_:) has been added as a protocol requirement | ||
| Func BinaryInteger.\/(_:_:) has been added as a protocol requirement | ||
| Func BinaryInteger.\/=(_:_:) has been added as a protocol requirement |
There was a problem hiding this comment.
This looks like something got escaped improperly.
|
I'm kind of terrified that these weren't being checked before. |
|
We were not checking them for api stability, but we will when we start to generate baseline for abi stability and check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.